-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package docs build workflow: use relaxed or tested requirements #2271
base: devel
Are you sure you want to change the base?
Conversation
This change updates the build package docs workflow to use either relaxed or tested requirements files.
e4e6e55
to
b5695da
Compare
Honestly, I wonder if we should just remove the relaxed dependencies file. I never end up using it. If I need to test a requirement change locally, I just edit the main constraints file and re-run pip-compile. |
Removing does mean one less thing to deal with. I'm fine with it personally but would like to hear what @felixfontein has to say. The whole point is to give him (and you) a set of dependencies to hack around with for dev purposes, as I'm sure you know. |
Wasn't the purpose of the relaxed dependencies to use them for some docsite build (ansible-core devel or ansible devel), so that we'd have an "early warning" in case something breaks? (I don't use the relaxed deps either.) |
Thanks @felixfontein From what I recall the relaxed dependencies were intended as a replacement for that one Should we close this PR? |
Fixes #2270
This change updates the build package docs workflow to use either relaxed or tested requirements files.
I've pushed an additional commit to consolidate the two steps but I'm not sure if it's a good idea. On the one hand, it's tidier in the workflow file but maybe less obvious which set of requirements get installed when looking at the run.